Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash creating new stream message in streams with no previous conversation. #247

Closed
sumanthvrao opened this issue Jan 9, 2019 · 1 comment
Closed

Crash creating new stream message in streams with no previous conversation. #247

sumanthvrao opened this issue Jan 9, 2019 · 1 comment
Assignees
@sumanthvrao
Labels
bug Something isn't working good first issue Good for newcomers help wanted This issue should be clear enough to work on high priority should be done as soon as possible in progress

Comments

@sumanthvrao
Copy link
Member

sumanthvrao commented Jan 9, 2019 •
edited
Loading

The c Hot Key works in creating a new stream message works in streams which has previous conversations. However the terminal crashes when used in streams which do not have any previous conversation. Expecting the Key to create a new message with stream set to current one and topic blank.

Steps to reproduce bug in development environment (newest version) :

  1. logged in as Iago@zulip.com
  2. Use c in to create new messages in streams with no convo like #sales, #support
  3. ZT crashes with the following error message
File "/home/sumanthvrao/.local/share/virtualenvs/zulip-terminal-sRIAC_7x/lib/python3.6/site-packages/urwid/container.py", line 1429, in _set_focus_position
    raise IndexError("No Pile child widget at position %s" % (position,))
IndexError: No Pile child widget at position 0
Zulip Terminal has crashed!

A workaround which avoids the error is to change Stream in message header (to #sales for example) when c is used to create new messages in streams with previous conversation.
@amanagr amanagr added bug Something isn't working help wanted This issue should be clear enough to work on good first issue Good for newcomers high priority should be done as soon as possible next major release labels Jan 9, 2019
@amanagr
Copy link
Member

amanagr commented Jan 9, 2019

@sumanthvrao thanks for reporting this.

sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Jan 12, 2019
@sumanthvrao
view: Fix Support for c HotKey in new streams.
74a3e34 
c HotKey used to crash zt when used in streams
with no previous messages. c now calls stream_box_view
while opening footer and sets name to stream name.

Fixes: zulip#247.
@sumanthvrao sumanthvrao mentioned this issue Jan 12, 2019
Merged
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Jan 13, 2019
@sumanthvrao
view: Fix Support for HotKeys in new streams.
8f3cce3 
c, r and R HotKey used to crash zt when used in streams
with no previous messages. c now calls stream_box_view
while opening footer and sets name to stream name.
r and R perform noop.

Fixes: zulip#247.

view: Fix support for HotKeys.
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Jan 13, 2019
@sumanthvrao
view: Fix Support for HotKeys in new streams.
4fb9b73 
c, r and R HotKey used to crash zt when used in streams
with no previous messages. c now calls stream_box_view
while opening footer and sets name to stream name.
r and R perform noop.

Fixes: zulip#247.

view: Fix support for HotKeys.
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Jan 14, 2019
@sumanthvrao
view: Fix Support for HotKeys in new streams.
1d8a273 
c, r, R, +, * and J/Pagedown HotKey used to crash zt
when used in streams with no previous messages.
c now calls stream_box_view while opening footer
and sets name to stream name. r, R, +, * and
J/Pagedown perform noop.

Fixes: zulip#247.
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Jan 15, 2019
@sumanthvrao
view: Fix Support for HotKeys in new streams.
0149763 
c, r, R, +, * and J/Pagedown HotKey used to crash zt
when used in streams with no previous messages.
c now calls stream_box_view while opening footer
and sets name to stream name. r, R, +, * and
J/Pagedown perform noop.

Fixes: zulip#247.
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Jan 17, 2019
@sumanthvrao
view: Fix Support for HotKeys in new streams.
3590fcd 
c, r, R, +, * ,J/Pagedown and K/Pageup HotKey
used to crash zt when used in streams with
no previous messages. c now calls
stream_box_view while opening footer
and sets name to stream name. r, R, +, * and
J/Pagedown and K/Pageup perform noop.

Fixes: zulip#247.
neiljp pushed a commit that referenced this issue Jan 21, 2019
@sumanthvrao @neiljp
view: Fix Support for HotKeys in new streams.
d3248d7 
c, r, R, +, * ,J/Pagedown and K/Pageup HotKey
used to crash zt when used in streams with
no previous messages. c now calls
stream_box_view while opening footer
and sets name to stream name. r, R, +, * and
J/Pagedown and K/Pageup perform noop.

Fixes: #247.
vonknio pushed a commit to vonknio/zulip-terminal that referenced this issue Jan 27, 2019
@sumanthvrao @vonknio
view: Fix Support for HotKeys in new streams.
8f2028b 
c, r, R, +, * ,J/Pagedown and K/Pageup HotKey
used to crash zt when used in streams with
no previous messages. c now calls
stream_box_view while opening footer
and sets name to stream name. r, R, +, * and
J/Pagedown and K/Pageup perform noop.

Fixes: zulip#247.
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Jan 31, 2019
@sumanthvrao
Updated bug fixes for issues zulip#247, zulip#259, zulip#266.
bc9acd2
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Jan 31, 2019
@sumanthvrao
changelog: Added fixes for issues zulip#247, zulip#259, zulip#266.
629bab6
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Feb 1, 2019
@sumanthvrao
changelog: Added fixes for issues zulip#247, zulip#259, zulip#266.
94e9100
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Feb 1, 2019
@sumanthvrao
changelog: Added fixes for issues zulip#247, zulip#259, zulip#266.
a601d9c
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Feb 3, 2019
@sumanthvrao
changelog: Added fixes for issues zulip#247, zulip#259, zulip#266.
5a3a105
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Feb 3, 2019
@sumanthvrao
changelog: Added fixes for issues zulip#247, zulip#259, zulip#266.
ee8c025
@neiljp neiljp mentioned this issue Feb 7, 2019
Open
2 tasks
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Feb 8, 2019
@sumanthvrao
changelog: Added fixes for issues zulip#247, zulip#259, zulip#266.
dbc36cd
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Feb 9, 2019
@sumanthvrao
changelog: Added fixes for issues zulip#247, zulip#259, zulip#266.
b4689f8
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Feb 9, 2019
@sumanthvrao
changelog: Added fixes for issues zulip#247, zulip#259, zulip#266.
0600849
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Feb 18, 2019
@sumanthvrao
changelog: Added fixes for issues zulip#247, zulip#259, zulip#266.
77ee3de
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Feb 19, 2019
@sumanthvrao
changelog: Added fixes for issues zulip#247, zulip#259, zulip#266.
7645da8
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Feb 19, 2019
@sumanthvrao
changelog: Added fixes for issues zulip#247, zulip#259, zulip#266.
79a6cbe
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Feb 19, 2019
@sumanthvrao
changelog: Added fixes for issues zulip#247, zulip#259, zulip#266.
97c37d2
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Feb 20, 2019
@sumanthvrao
changelog: Added fixes for issues zulip#247, zulip#259, zulip#266.
f2ae496
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Feb 21, 2019
@sumanthvrao
changelog: Added fixes for issues zulip#247, zulip#259, zulip#266.
3593203
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Feb 27, 2019
@sumanthvrao
changelog: Added fixes for issues zulip#247, zulip#259, zulip#266.
11b6ee3
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Mar 3, 2019
@sumanthvrao
changelog: Added fixes for issues zulip#247, zulip#259, zulip#266.
7bc7701
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Mar 3, 2019
@sumanthvrao
changelog: Added fixes for issues zulip#247, zulip#259, zulip#266.
7d85f07
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Mar 5, 2019
@sumanthvrao
changelog: Added fixes for issues zulip#247, zulip#259, zulip#266.
d81ac28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sumanthvrao sumanthvrao

Labels
bug Something isn't working good first issue Good for newcomers help wanted This issue should be clear enough to work on high priority should be done as soon as possible in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@amanagr @zulipbot @sumanthvrao