All/everyone/stream mentions don't show up in mentions narrow #1037
Comments
|
Also see #zulip-terminal>Bug: "all" mentions for original report and possible future discussion. |
|
@neiljp Thanks for mentioning the stream and identifying the issue. 👍 |
zee-bit
added a commit
to zee-bit/zulip-terminal
that referenced
this issue
May 25, 2021
This commit fixes a small bug that prevented messages with wildcard_mentions from appearing in the all_mentions narrow. The server defines several wildcard_mentions like @all/@everyone /@stream, which are not marked with 'mentions' in the message flags, but rather 'wildcard_mentions'. The bugfix now checks for this flag in the message response from server and appropriately categorizes these messages as mentioned and also updates the count in the respective narrows. Also fixes a related expression in model's current_narrow_contains_message function, that did not check for 'wildcard_mentioned' in message flags. Tests amended. Fixes zulip#1037.
zee-bit
added a commit
to zee-bit/zulip-terminal
that referenced
this issue
May 28, 2021
This commit fixes a small bug that prevented messages with wildcard_mentions from appearing in the all_mentions narrow. The server defines several wildcard_mentions like @all/@everyone /@stream, which are not marked with 'mentions' in the message flags, but rather 'wildcard_mentions'. The bugfix now checks for this flag in the message response from server and appropriately categorizes these messages as mentioned and also updates the count in the respective narrows. Also fixes a related expression in model's current_narrow_contains_message function, that did not check for 'wildcard_mentioned' in message flags. Tests amended. Fixes zulip#1037.
zee-bit
added a commit
to zee-bit/zulip-terminal
that referenced
this issue
Jun 1, 2021
This commit fixes a small bug that prevented messages with wildcard_mentions from appearing in the all_mentions narrow. The server defines several wildcard_mentions like @all/@everyone /@stream, which are not marked with 'mentions' in the message flags, but rather 'wildcard_mentions'. The bugfix now checks for this flag in the message response from server and appropriately categorizes these messages as mentioned and also updates the count in the respective narrows. Also fixes a related expression in model's current_narrow_contains_message function, that did not check for 'wildcard_mentioned' in message flags. Tests amended. Fixes zulip#1037.
zee-bit
added a commit
to zee-bit/zulip-terminal
that referenced
this issue
Jun 3, 2021
This commit fixes a small bug that prevented messages with wildcard_mentions from appearing in the all_mentions narrow. The server defines several wildcard_mentions like @all/@everyone /@stream, which are not marked with 'mentions' in the message flags, but rather 'wildcard_mentions'. The bugfix now checks for this flag in the message response from server and appropriately categorizes these messages as mentioned and also updates the count in the respective narrows. Also fixes a related expression in model's current_narrow_contains_message function, that did not check for 'wildcard_mentioned' in message flags. Tests amended. Fixes zulip#1037.
zee-bit
added a commit
to zee-bit/zulip-terminal
that referenced
this issue
Jun 4, 2021
This commit fixes a small bug that prevented messages with wildcard_mentions from appearing in the all_mentions narrow. The server defines several wildcard_mentions like @all/@everyone /@stream, which are not marked with 'mentions' in the message flags, but rather 'wildcard_mentions'. The bugfix now checks for this flag in the message response from server and appropriately categorizes these messages as mentioned and also updates the count in the respective narrows. Also fixes a related expression in model's current_narrow_contains_message function, that did not check for 'wildcard_mentioned' in message flags. Tests amended. Fixes zulip#1037.
zee-bit
added a commit
to zee-bit/zulip-terminal
that referenced
this issue
Jun 10, 2021
This commit fixes a small bug that prevented messages with wildcard_mentions from appearing in the all_mentions narrow. The server defines several wildcard_mentions like @all/@everyone /@stream, which are not marked with 'mentions' in the message flags, but rather 'wildcard_mentions'. The bugfix now checks for this flag in the message response from server and appropriately categorizes these messages as mentioned and also updates the count in the respective narrows. Also fixes a related expression in model's current_narrow_contains_message function, that did not check for 'wildcard_mentioned' in message flags. Tests amended. Fixes zulip#1037.
zee-bit
added a commit
to zee-bit/zulip-terminal
that referenced
this issue
Jun 19, 2021
This commit fixes a small bug that prevented messages with wildcard_mentions from appearing in the all_mentions narrow. The tests in conftest are also expanded to include wildcard_mentioned messages. This fixture now uses several combinations of mentioned and wildcard_mentioned message ids and pass them to other tests. The server defines several wildcard_mentions like @all/@everyone /@stream, which are not marked with 'mentions' in the message flags, but rather 'wildcard_mentions'. The bugfix now checks for this flag in the message response from server and appropriately categorizes these messages as mentioned and also updates the count in the respective narrows. This also fixes a related expression in model's current_narrow_contains_message function, which did not check for 'wildcard_mentioned' in message flags. Tests amended. Fixes zulip#1037.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@all,@everyoneand@streammentions don't seem to appear in the mentions narrow.I would recommend against testing the anomaly on any stream with a high subscriber count and would recommend using the zulip dev server.
The text was updated successfully, but these errors were encountered: