New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tag "bootstrap_javascript" with jquery=True and async problematic #52

Closed

rubenmoor opened this issue Dec 17, 2013 · 1 comment

rubenmoor commented Dec 17, 2013

{% bootscript_javascript jquery=True %} renders to

<script src="//code.jquery.com/jquery.min.js" async></script><script src="//netdna.bootstrapcdn.com/bootstrap/3.0.3/js/bootstrap.min.js" async></script>

I'm not positive about what 'async' does, but apparently sometimes jquery isn't loaded in time (this is: before bootstrap) and I got the error

Bootstrap requires jQuery

I entered the scripts manually, removed "async" from both and now it works without errors.

(thanks for this btw, really useful for me!)

Member

dyve commented Dec 18, 2013

OK, I hadn't noticed any side effects to async myself, but I'll remove the async from jQuery (needs to be loaded before anything else)

dyve added a commit that referenced this issue


          Fix issue #52 and add test for danger messages, bump to 2.5.1

102c172

dyve closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment