Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TagMacro: Spurious tag inequality when parameterizing type alias of intersection #189

Closed
neko-kai opened this issue Jun 7, 2021 · 3 comments
Closed

TagMacro: Spurious tag inequality when parameterizing type alias of intersection #189

neko-kai opened this issue Jun 7, 2021 · 3 comments
Assignees
@neko-kai
Labels
bug Something isn't working help wanted Extra attention is needed scala2

Comments

@neko-kai
Copy link
Member

neko-kai commented Jun 7, 2021

See 7mind/izumi#1523 (comment)
@pshirshov pshirshov added bug Something isn't working scala2 labels Sep 23, 2021
@pshirshov pshirshov changed the title Spurious tag inequality when parameterizing type alias of intersection TagMacro: Spurious tag inequality when parameterizing type alias of intersection Aug 2, 2022
pshirshov added a commit that referenced this issue Aug 2, 2022
@pshirshov
#189, progression test
dcc2ec9
@pshirshov
Copy link
Member

/~https://github.com/zio/izumi-reflect/blob/develop/izumi-reflect/izumi-reflect/src/test/scala/izumi/reflect/test/SharedTagProgressionTest.scala#L27

@pshirshov pshirshov mentioned this issue Aug 2, 2022
Closed
@pshirshov pshirshov added the help wanted Extra attention is needed label Aug 3, 2022
@neko-kai
Copy link
Member Author

neko-kai commented Jan 20, 2023 •
edited
Loading

Has associated progression test "progression test: reported in /~https://github.com/zio/izumi-reflect/issues/189, parameterized type alias with intersection produces incorrect output"

izumi-reflect/izumi-reflect/izumi-reflect/src/test/scala/izumi/reflect/test/SharedTagProgressionTest.scala

Line 29 in c0afe1b

"progression test: reported in /~https://github.com/zio/izumi-reflect/issues/189, parameterized type alias with intersection produces incorrect output" in {

@neko-kai
Copy link
Member Author

Relevant branch /~https://github.com/7mind/izumi/commits/feature/fix-type-alias-with

neko-kai added a commit that referenced this issue Apr 25, 2023
@neko-kai
Fix detection of generic type projections as 'weak' types on Scala 2 …
d95d887 
…when obscured by type alias, also fix #189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neko-kai neko-kai

Labels
bug Something isn't working help wanted Extra attention is needed scala2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pshirshov @neko-kai