Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add donation address to zingoconfig #854

Merged
merged 3 commits into from
Mar 31, 2024
Merged

Conversation

zancas
Copy link
Member

@zancas zancas commented Mar 23, 2024

No description provided.

Copy link
Contributor

@Oscar-Pepper Oscar-Pepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we merge this without it being used to add a command to send to this address it may just get lost in the code? Should this be the start of a PR that implements such a command?

@zancas
Copy link
Member Author

zancas commented Mar 30, 2024

It seems like @juanky201271 was able to access this address?

Any reason to not merge?

@juanky201271
Copy link
Contributor

It seems like @juanky201271 was able to access this address?

Any reason to not merge?

I wasn't actually, I copied here: /~https://github.com/zingolabs/zingo-mobile/blob/6a7643100973dfe95ad1bfe7913fb2909487cd67/app/utils/Utils.ts#L99 waiting for accessing to this constant in zingolib, but I guess I need a command or something to get this UA from zingolib...

Copy link
Contributor

@fluidvanadium fluidvanadium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@zancas zancas merged commit e3e6171 into zingolabs:dev Mar 31, 2024
16 checks passed
@zancas zancas deleted the donation_address branch March 31, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants