Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix output format for txids in sendprogress command #1545

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Fix output format for txids in sendprogress command #1545

merged 2 commits into from
Nov 22, 2024

Conversation

dorianvp
Copy link
Member

No description provided.

@dorianvp dorianvp self-assigned this Nov 22, 2024
@dorianvp
Copy link
Member Author

Running a CLT...

@dorianvp
Copy link
Member Author 

------------
     Summary [ 794.964s] 336 tests run: 336 passed (112 slow), 30 skipped


git show -s
commit 725a59c85396bf8d34dce78d9324b3dd7bd81edc (HEAD, dorian/sendprogress-out-format)
Author: dorianvp <dariovp01@gmail.com>
Date:   Thu Nov 21 23:31:42 2024 -0300

    fix: use json format for tx ids

@zancas
Copy link
Member

zancas commented Nov 22, 2024

I"m running a CLT, in the meantime let's ship this to @juanky201271 for a manual test?

@zancas zancas merged commit af35475 into zingolabs:dev Nov 22, 2024
9 checks passed
@juanky201271
Copy link
Contributor

Thanks @dorianvp I believe that this PR fixed this issue: #1469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zancas zancas zancas approved these changes

@fluidvanadium fluidvanadium Awaiting requested review from fluidvanadium

@juanky201271 juanky201271 Awaiting requested review from juanky201271

Assignees

@dorianvp dorianvp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dorianvp @zancas @juanky201271