run_actions_on_self_hosted #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nachog00
changed the title
ci.yaml
zancas
previously approved these changes
Oct 17, 2024
Idea is to have this dep already in the runner image, but not break github hosted runner compatibility.
|
Hi @nachog00 is this PR still active? Or has it been superceded? |
no. When self hosted runners handle jobs correctly, merging this will make all jobs be picked up by them. |
Sorry, wrong branch. Should have been applied in `update_ci_image` This reverts commit 0c998b0.
… that it shares the same glibc version
Don't see the reason for it. Seems to defeat the idea of running within a container. Will re-add it later if the need arises.
fluidvanadium
requested changes
Oct 30, 2024
zancas
approved these changes
Oct 30, 2024
|
Since this is blocked on CI... and since it should speed up CI, I am going to merge it. |
This was referenced Oct 31, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the self-hosted runner to pick up on actions jobs, they must have the property:
runs-on: self-hosted
I changed only the jobs on CI.yaml for now.