Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detailed tx summaries #1271

Merged
merged 9 commits into from
Jul 21, 2024
Merged

Conversation

Oscar-Pepper
Copy link
Contributor

@Oscar-Pepper Oscar-Pepper commented Jul 5, 2024

for debugging and advanced zingo-cli users
currently, detailed tx summary only adds nullifiers but there may be other things that will be useful to add in the future such as the notes spent in a tx etc.

@Oscar-Pepper Oscar-Pepper marked this pull request as ready for review July 6, 2024 19:41
@Oscar-Pepper Oscar-Pepper force-pushed the detailed_tx_summaries branch from a40e131 to 8f92c16 Compare July 6, 2024 21:37
fluidvanadium
fluidvanadium previously approved these changes Jul 8, 2024
Copy link
Contributor

@fluidvanadium fluidvanadium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok!

@Oscar-Pepper Oscar-Pepper marked this pull request as draft July 9, 2024 13:31
@Oscar-Pepper Oscar-Pepper marked this pull request as ready for review July 9, 2024 15:59
@fluidvanadium
Copy link
Contributor

i will test it out in zingocli when i get a chance

zancas
zancas previously approved these changes Jul 21, 2024
@zancas
Copy link
Member

zancas commented Jul 21, 2024

@Oscar-Pepper it seems that there's a CI fail.

@zancas zancas merged commit 4873a7b into zingolabs:dev Jul 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants