Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move SQLResultAdapter is close to RowDecoder #115

Closed
zero88 opened this issue Apr 13, 2022 · 0 comments · Fixed by #128 or #131
Closed

Move SQLResultAdapter is close to RowDecoder #115

zero88 opened this issue Apr 13, 2022 · 0 comments · Fixed by #128 or #131
Labels
breaking-changes C: perf CL: Medium Complexity level: medium P: High T: Feature Issue Type: Feature
Milestone
Version 2.0.0-rc1

Comments

@zero88
Copy link
Owner

zero88 commented Apr 13, 2022 •
edited
Loading

Motivation

The current SQLResultAdapter is called after Vertx SQL client executes the SQL query then stores the result into Vertx ResultSet (RowSet<Row>). It will affect performance when looping on the result set once more time, to make the output to JSON record.

To improve the performance and reduce the converter time, need to make SQLResultAdapter is as Vertx collectors, that will be invoked in RowDecoder

The SQLResultAdapter can be used as collector or mapper
@zero88 zero88 added CL: Medium Complexity level: medium P: High T: Feature Issue Type: Feature C: perf labels Apr 13, 2022
@zero88 zero88 changed the title Move SQLResultAdapter to closed to RowDecoder Move SQLResultAdapter to enclose to RowDecoder Apr 18, 2022
@zero88 zero88 changed the title Move SQLResultAdapter to enclose to RowDecoder Move SQLResultAdapter is close to RowDecoder May 26, 2022
zero88 added a commit that referenced this issue Jul 15, 2022
@zero88
[#115] Rename generic type name in jooqx.adapter package
ef06456
zero88 added a commit that referenced this issue Aug 5, 2022
@zero88
[#115] Refactor SQLResultAdapter and SQLResultCollector
4d94abf
zero88 added a commit that referenced this issue Aug 5, 2022
@zero88
[#115] Refactor RecordFactory
c2dbb7f 
[#115] Add FieldWrapper to be able to fallback get value by column number
zero88 added a commit that referenced this issue Aug 5, 2022
@zero88
[#115] Refactor BatchResult & BatchReturningResult
ff5a9fc
@zero88 zero88 mentioned this issue Aug 5, 2022
Merged
zero88 added a commit that referenced this issue Aug 5, 2022
@zero88
[#115] Refactor SQLResultAdapter and SQLResultCollector
54fd193
zero88 added a commit that referenced this issue Aug 5, 2022
@zero88
[#115] Refactor RecordFactory
3562198 
[#115] Add FieldWrapper to be able to fallback get value by column number
zero88 added a commit that referenced this issue Aug 5, 2022
@zero88
[#115] Refactor BatchResult & BatchReturningResult
2b2d4b7
zero88 added a commit that referenced this issue Aug 5, 2022
@zero88
[#115] Add TooManyRowsException if single row query returns more than…
326c8fb 
… one row
zero88 added a commit that referenced this issue Aug 5, 2022
@zero88
[#115] Add TooManyRowsException if single row query returns more than…
15066e2 
… one row
@zero88 zero88 added this to the Version 2.0.0-rc1 milestone Aug 6, 2022
@zero88 zero88 reopened this Aug 6, 2022
zero88 added a commit that referenced this issue Aug 6, 2022
@zero88
[#115] Use collector when executing query
21b8553
zero88 added a commit that referenced this issue Aug 6, 2022
@zero88
[#115] Use collector when executing batch and routine
541438f
zero88 added a commit that referenced this issue Aug 6, 2022
@zero88
[#115] Refactor SQLBatchCollector
e87f203
zero88 added a commit that referenced this issue Aug 6, 2022
@zero88
[#115] Refactor SQLResultCollector: remove generic type
863353b
@zero88 zero88 mentioned this issue Aug 6, 2022
Merged
zero88 added a commit that referenced this issue Aug 6, 2022
@zero88
[#115] Refactor SQLBatchCollector
82b0f9b
zero88 added a commit that referenced this issue Aug 6, 2022
@zero88
[#115] Refactor SQLResultCollector: remove generic type
4fd7590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-changes C: perf CL: Medium Complexity level: medium P: High T: Feature Issue Type: Feature
Projects
None yet
Milestone
Version 2.0.0-rc1
1 participant
@zero88