-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: serial: stm32: use generic LL headers #28894
drivers: serial: stm32: use generic LL headers #28894
Conversation
@@ -28,6 +28,14 @@ | |||
#include <drivers/clock_control/stm32_clock_control.h> | |||
#include "uart_stm32.h" | |||
|
|||
#include <stm32_ll_usart.h> | |||
#include <stm32_ll_lpuart.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several soc.h
don't include stm32*_ll_lpuart.h
header files at the moment, is this handled with dummy/empty include files in the stm32_hal
repo ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lowlander Yes. Generated headers only contain entries for families that have the API.
That's a great contribution to simplify adding driver support for new MCU series. And also helps to clean up my out-of-tree drivers. Definitely +1 from my side once the PR is merged to hal_stm32. |
|
@gmarull, would you mind rebasing ? |
@erwango done |
@lowlander, @martinjaeger, @Nukersson, @lochej this PR requires some more positive reviews to get in. |
Thank you. I will be able to review it only at the weekend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gmarull. Looks good!
Are you planning to submit a PR for the other peripherals aswell?
Maybe that's an effort that can be shared |
@erwango agree, contributions are welcome :-) |
Use generic LL headers instead of depending on soc.h. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
Sure, I'm happy to support. Just didn't want to work on a PR if you have something in the pipeline already. I can look into a few peripherals this afternoon (let's say at least CAN, ADC, DAC). |
@martinjaeger sounds good! |
This PR is a proposal to improve LL HAL API usage by introducing generic LL headers. The full details of the proposal can be found in #28822. Companion PR: zephyrproject-rtos/hal_stm32#68
Resolves #28822