Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: serial: stm32: use generic LL headers #28894

Merged
merged 1 commit into from
Nov 24, 2020
Merged

drivers: serial: stm32: use generic LL headers #28894

merged 1 commit into from
Nov 24, 2020

Conversation

gmarull
Copy link
Member

@gmarull gmarull commented Oct 3, 2020

This PR is a proposal to improve LL HAL API usage by introducing generic LL headers. The full details of the proposal can be found in #28822. Companion PR: zephyrproject-rtos/hal_stm32#68

Resolves #28822

@gmarull gmarull requested review from erwango, FRASTM and ABOSTM October 3, 2020 22:03
@gmarull gmarull requested review from lowlander and lochej October 3, 2020 22:03
@gmarull gmarull added the RFC Request For Comments: want input from the community label Oct 3, 2020
@gmarull gmarull requested a review from martinjaeger October 3, 2020 22:14
@@ -28,6 +28,14 @@
#include <drivers/clock_control/stm32_clock_control.h>
#include "uart_stm32.h"

#include <stm32_ll_usart.h>
#include <stm32_ll_lpuart.h>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several soc.h don't include stm32*_ll_lpuart.h header files at the moment, is this handled with dummy/empty include files in the stm32_hal repo ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martinjaeger
Copy link
Member

That's a great contribution to simplify adding driver support for new MCU series. And also helps to clean up my out-of-tree drivers. Definitely +1 from my side once the PR is merged to hal_stm32.

@KozhinovAlexander
Copy link
Collaborator

KozhinovAlexander commented Oct 10, 2020

west.yml looks to have conflicts after merge or rebase. Can you please provide proper changes to it? Otherwise LGTM! And good work!

@gmarull gmarull requested a review from arnopo as a code owner October 10, 2020 15:19
@gmarull gmarull changed the title [RFC] drivers: serial: stm32: use generic LL headers drivers: serial: stm32: use generic LL headers Nov 6, 2020
@gmarull gmarull requested a review from lowlander November 6, 2020 23:24
@gmarull
Copy link
Member Author

gmarull commented Nov 6, 2020

@erwango @ABOSTM should be ready now.

@erwango
Copy link
Member

erwango commented Nov 19, 2020

@gmarull, would you mind rebasing ?

@gmarull
Copy link
Member Author

gmarull commented Nov 20, 2020

@erwango done

@erwango
Copy link
Member

erwango commented Nov 20, 2020

@lowlander, @martinjaeger, @Nukersson, @lochej this PR requires some more positive reviews to get in.

@KozhinovAlexander
Copy link
Collaborator

@lowlander, @martinjaeger, @Nukersson, @lochej this PR requires some more positive reviews to get in.

Thank you. I will be able to review it only at the weekend.

Copy link
Member

@martinjaeger martinjaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gmarull. Looks good!

Are you planning to submit a PR for the other peripherals aswell?

@erwango
Copy link
Member

erwango commented Nov 20, 2020

Are you planning to submit a PR for the other peripherals aswell?

Maybe that's an effort that can be shared

@gmarull
Copy link
Member Author

gmarull commented Nov 20, 2020

Are you planning to submit a PR for the other peripherals aswell?

Maybe that's an effort that can be shared

@erwango agree, contributions are welcome :-)

Use generic LL headers instead of depending on soc.h.

Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
@martinjaeger
Copy link
Member

Are you planning to submit a PR for the other peripherals aswell?

Maybe that's an effort that can be shared

@erwango agree, contributions are welcome :-)

Sure, I'm happy to support. Just didn't want to work on a PR if you have something in the pipeline already. I can look into a few peripherals this afternoon (let's say at least CAN, ADC, DAC).

@gmarull
Copy link
Member Author

gmarull commented Nov 20, 2020

@martinjaeger sounds good!

@erwango erwango requested review from carlescufi and galak November 20, 2020 13:23
@carlescufi carlescufi merged commit e83fab3 into zephyrproject-rtos:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Modules platform: STM32 ST Micro STM32 RFC Request For Comments: want input from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve STM32 LL HAL usage
6 participants