This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Bring fluid interface to Feed Writer #2694
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please add unit tests for the fluent interface? Also, you evidently need to rebase. Thanks! |
ghost
assigned 
|
Unit test for fluent interface ? Just check that the value returned is the same as the original object ? I can do that. |
|
Yes, exactly. You can actually test all methods that implement a fluent interface at once -- simply chain all the calls, and verify you receive an instance of the original class. |
|
Done. |
| ->setTitle('foo') | ||
| ->setType('foo'); | ||
|
|
||
| $this->assertEquals($return, $writer); |
There was a problem hiding this comment.
This should be assertSame() -- assertEquals() can compare two objects for equality, without them being the same object. I'll update this on merge.
weierophinney
added a commit
that referenced
this pull request
Oct 16, 2012
- Test for same object, not equality of objects, when testing fluent interface
weierophinney
added a commit
to zendframework/zend-feed
that referenced
this pull request
May 15, 2015
- Test for same object, not equality of objects, when testing fluent interface
weierophinney
added a commit
to zendframework/zend-feed
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-feed
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings fluid interface to Feed writer.