Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move zcash_note_encryption component to /~https://github.com/zcash/zcash_note_encryption #1041

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

nuttycom
Copy link
Contributor

@nuttycom nuttycom commented Nov 18, 2023

The zcash_note_encryption component crate has been factored out to its own repository, to avoid circular crate dependencies involving /~https://github.com/zcash/librustzcash and the
/~https://github.com/zcash/orchard and
/~https://github.com/zcash/sapling-crypto repositories.

The removed state corresponds to zcash/zcash_note_encryption@9c76d57

Part of #768.

…ash_note_encryption

The `zcash_note_encryption` component crate has been factored out to
its own repository, to avoid circular crate dependencies involving
/~https://github.com/zcash/librustzcash and the
/~https://github.com/zcash/orchard and
/~https://github.com/zcash/sapling-crypto repositories.
Copy link

codecov bot commented Nov 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (236cd56) 69.79% compared to head (374882b) 70.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1041      +/-   ##
==========================================
+ Coverage   69.79%   70.69%   +0.89%     
==========================================
  Files         142      140       -2     
  Lines       13959    13782     -177     
==========================================
  Hits         9743     9743              
+ Misses       4216     4039     -177     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. I verified that zcash/zcash_note_encryption@9c76d57 is identical to the components/zcash_note_encryption directory at 236cd56 (the direct parent of this PR). We are fine to depend on the published crate release because we have not made any changes to zcash_note_encryption since its last release that are required in this repo.

@str4d str4d merged commit 95e092b into zcash:main Nov 18, 2023
16 checks passed
@nuttycom nuttycom deleted the extract_zcash_note_encryption branch November 18, 2023 04:31
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-hoc ACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants