-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(optimizer): allow circuit manipulation in optimizer dag #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 975b03a | Previous: 9b2e39f | Ratio |
---|---|---|---|
v0 PBS table generation |
58712583 ns/iter (± 323798 ) |
58193215 ns/iter (± 1655896 ) |
1.01 |
v0 PBS simulate dag table generation |
39182216 ns/iter (± 264223 ) |
36003903 ns/iter (± 506816 ) |
1.09 |
v0 WoP-PBS table generation |
66906120 ns/iter (± 1103999 ) |
66119659 ns/iter (± 1172512 ) |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
BourgerieQuentin
requested changes
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are minor comments, need @rudy-6-4 review too 🙏
compilers/concrete-compiler/compiler/lib/Dialect/FHE/Analysis/ConcreteOptimizer.cpp
Outdated
Show resolved
Hide resolved
compilers/concrete-compiler/compiler/lib/Support/CompilerEngine.cpp
Outdated
Show resolved
Hide resolved
compilers/concrete-optimizer/concrete-optimizer/src/dag/unparametrized.rs
Outdated
Show resolved
Hide resolved
compilers/concrete-optimizer/concrete-optimizer/src/dag/unparametrized.rs
Outdated
Show resolved
Hide resolved
compilers/concrete-optimizer/concrete-optimizer/src/dag/unparametrized.rs
Outdated
Show resolved
Hide resolved
compilers/concrete-optimizer/concrete-optimizer/src/dag/unparametrized.rs
Outdated
Show resolved
Hide resolved
compilers/concrete-optimizer/concrete-optimizer/src/dag/unparametrized.rs
Show resolved
Hide resolved
compilers/concrete-optimizer/concrete-optimizer/src/dag/unparametrized.rs
Show resolved
Hide resolved
compilers/concrete-optimizer/concrete-optimizer/src/dag/unparametrized.rs
Show resolved
Hide resolved
68c79d0
to
f79e543
Compare
f79e543
to
0218205
Compare
BourgerieQuentin
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.