Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(concretre-compiler): do not optimize llvm twice #502

Merged
merged 1 commit into from
Sep 8, 2023
Merged

fix(concretre-compiler): do not optimize llvm twice #502

merged 1 commit into from
Sep 8, 2023

Conversation

rudy-6-4
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla-signed label Jul 11, 2023
@rudy-6-4 rudy-6-4 force-pushed the fix/compiler/no-twice-opt branch from 9afd2c1 to 7f0bfb6 Compare July 11, 2023 09:56
@rudy-6-4 rudy-6-4 mentioned this pull request Jul 11, 2023
Closed
@rudy-6-4
Copy link
Contributor Author

Partially replace: #401

BourgerieQuentin
BourgerieQuentin requested changes Jul 31, 2023
View reviewed changes
Copy link
Member

@BourgerieQuentin BourgerieQuentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for now the targetMachine should always be the host it should work, but if we activate cross compilation in the future maybe it could be great to keep that here and remove the optimizeLLVMModule pass ? wdyt?

@rudy-6-4
Copy link
Contributor Author

rudy-6-4 commented Aug 2, 2023

As for now the targetMachine should always be the host it should work, but if we activate cross compilation in the future maybe it could be great to keep that here and remove the optimizeLLVMModule pass ? wdyt?

Yes it could be done the other way. I put it here because it's with the legacy pass manager so I had chosen to rely on the recent code to handle the optimisation (optimizeLLVMModule).

@rudy-6-4 rudy-6-4 force-pushed the fix/compiler/no-twice-opt branch from 7f0bfb6 to 28b4e01 Compare September 8, 2023 12:54
@rudy-6-4 rudy-6-4 force-pushed the fix/compiler/no-twice-opt branch from 28b4e01 to 1177444 Compare September 8, 2023 12:56
@rudy-6-4
Copy link
Contributor Author

rudy-6-4 commented Sep 8, 2023

@slab-ci compiler-cpu-benchmark
to compare compilation time

@rudy-6-4 rudy-6-4 merged commit 229bbc2 into main Sep 8, 2023
@rudy-6-4 rudy-6-4 deleted the fix/compiler/no-twice-opt branch January 24, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BourgerieQuentin BourgerieQuentin BourgerieQuentin approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rudy-6-4 @BourgerieQuentin