Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: parse Date scalar object arguments properly #158

Merged
merged 3 commits into from
Mar 11, 2022
Merged

fix: parse Date scalar object arguments properly #158

merged 3 commits into from
Mar 11, 2022

Conversation

andrew0
Copy link
Contributor

@andrew0 andrew0 commented Feb 9, 2022

Fixes #157.

@boopathi
Copy link
Member

Thanks for your PR! The PR looks good.

Though this solves the problem specifically for Date objects, I wonder if it can be better handled for any custom class. I’ll review the change more thoroughly this week.

@ruiaraujo
Copy link
Collaborator

@boopathi i think we need to offer a hook to register custom transformers for the leaf serializers.

@flashspys
Copy link

As Date is a very popular object, is it possible to merge this MR already and open a new issue for custom transformers?

@oporkka
Copy link
Member

oporkka commented Mar 11, 2022

👍

1 similar comment
@boopathi
Copy link
Member

👍

@boopathi
Copy link
Member

We will explore more about custom classes in future. For now supporting Date looks important. Thank you!

@boopathi boopathi merged commit 745c9aa into zalando-incubator:main Mar 11, 2022
@flashspys
Copy link

It would be awesome, if you could create a new release with this change ❤️

@tuan231195
Copy link

please create a new release with this change

boopathi added a commit that referenced this pull request May 24, 2022
@boopathi
Bump release to 0.7.4
292b1f7 
- fix: parse Date scalar object arguments properly (#158)
- fix: apply directives skip/include for mutation (#172)
- upgrade dependencies: minimist, async, fast-json-stringify
@boopathi boopathi mentioned this pull request May 24, 2022
Merged
boopathi added a commit that referenced this pull request May 24, 2022
@boopathi
Bump release to 0.7.4 (#173)
0324974 
- fix: parse Date scalar object arguments properly (#158)
- fix: apply directives skip/include for mutation (#172)
- upgrade dependencies: minimist, async, fast-json-stringify
@oporkka
Copy link
Member

oporkka commented May 24, 2022

please create a new release with this change

@tuan231195 @flashspys sorry for the delay. There is now a release with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boopathi boopathi boopathi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-primitive custom scalar argument gets coerced to a string
6 participants
@andrew0 @boopathi @ruiaraujo @flashspys @oporkka @tuan231195