Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(README): markdown Usage Important section bit misspell #755

Merged
merged 6 commits into from
Nov 20, 2023

Conversation

guspan-tanadi
Copy link
Contributor

@guspan-tanadi guspan-tanadi commented Nov 19, 2023

Blockquote markdown Important in Usage section following consider bit misspell.

@ghost
Copy link

ghost commented Nov 19, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Owner

@yykamei yykamei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I didn't know alerts! Cool 😎

@yykamei
Copy link
Owner

yykamei commented Nov 19, 2023

Hi @guspan-tanadi,

I like this pull request and want to merge it, but Prettier doesn't seem to support this feature yet. I would like to format the Markdown using Prettier with less effort. Do you know Prettier would support Alerts? I'm ready to merge it if Alerts can be formatted with Prettier.

@guspan-tanadi guspan-tanadi marked this pull request as draft November 20, 2023 01:50
@yykamei yykamei marked this pull request as ready for review November 20, 2023 07:14
@yykamei yykamei merged commit 845c2d6 into yykamei:main Nov 20, 2023
4 checks passed
@yykamei
Copy link
Owner

yykamei commented Nov 20, 2023

@guspan-tanadi

Thank you for formatting the file. I merged the pull request since I think the change is completely great!

@guspan-tanadi guspan-tanadi deleted the alertmarkdown branch November 20, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants