Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the default loadBalance to LoadBalanceType.FALSE #23

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Set the default loadBalance to LoadBalanceType.FALSE #23

merged 3 commits into from
Oct 1, 2024

Conversation

ashetkar
Copy link

@ashetkar ashetkar commented Sep 27, 2024 •
edited
Loading

What

  • Fix NPE when the load-balance property is not set (GH issue).
  • The NPE is a regression in 42.3.5-yb-7 because the property load-balance changed from boolean (which defaulted to false even though it was not explicitly set) to an enum type, which needs to be set explicitly.

Testing

@ashetkar ashetkar merged commit b42efc6 into master Oct 1, 2024
2 checks passed
@ashetkar ashetkar deleted the db-13061 branch October 1, 2024 12:11
ashetkar added a commit that referenced this pull request Oct 7, 2024
@ashetkar
(git cherry-pick -n b42efc6) Set the default loadBalance to LoadBalan…
281d99c 
…ceType.FALSE (#23)

* Set the default loadBalance to LoadBalanceType.FALSE
* Update version to 42.3.5-yb-8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarshDaryani896 HarshDaryani896 HarshDaryani896 approved these changes

@kneeraj kneeraj Awaiting requested review from kneeraj

@Sfurti-yb Sfurti-yb Awaiting requested review from Sfurti-yb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashetkar @HarshDaryani896