Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to use libavformat runtime version when adding aac_adtstoasc filter #29581

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ghost
Copy link

@ghost ghost commented Jul 18, 2021

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Should resolve #28501, and maybe #28078

Changes to use libavformat runtime version to determine supported features when adding aac_adtstoasc filter.
The filter is automatically added in libavformat.
libavformat 57.56.100 corresponds to ffmpeg 3.2

@ghost ghost closed this Jul 19, 2021
@ghost
Copy link
Author

ghost commented Jul 19, 2021

Added to extract libavformat build version. I'm going to use this in my next PR.

@ghost ghost reopened this Jul 19, 2021
pukkandan added a commit to yt-dlp/yt-dlp that referenced this pull request Nov 3, 2021
pukkandan added a commit to yt-dlp/yt-dlp that referenced this pull request Nov 3, 2021
and print available features in verbose head
Based on ytdl-org/youtube-dl#29581
gaming-hacker added a commit to gaming-hacker/yt-dlp that referenced this pull request Nov 3, 2021
* master: (28 commits)
  [ffmpeg] Detect libavformat version for `aac_adtstoasc` and print available features in verbose head Based on ytdl-org/youtube-dl#29581
  [ffmpeg] Accurately detect presence of setts
  [ExtractAudio] Use `libfdk_aac` if available Closes yt-dlp#1502 Authored by: CrypticSignal
  [ffmpeg] Framework for feature detection Related: yt-dlp#1502, yt-dlp#1237, ytdl-org/youtube-dl#29581
  [ExtractAudio] Rescale --audio-quality correctly Authored by: CrypticSignal, pukkandan
  [fragment] Fix progress display in fragmented downloads Closes yt-dlp#1517
  [youtube] Remove unnecessary no-playlist warning
  [utils] Parse `vp09` as vp9
  [jsinterp] Handle default in switch better
  [Instagram] Fix incorrect resolution (yt-dlp#1494)
  [vk] Fix login (yt-dlp#1495)
  [docs,cleanup] Improve docs and minor cleanup Closes yt-dlp#1387, yt-dlp#1404, yt-dlp#1408, yt-dlp#1485, yt-dlp#1415, yt-dlp#1450, yt-dlp#1492
  [youtube] refactor itag processing
  [linkedin] Don't login multiple times
  [vk] Add subtitles (yt-dlp#1480)
  [Olympics] Fix extractor (yt-dlp#1483)
  [PlanetMarathi] Add extractor (yt-dlp#1484)
  [Instagram] Add login to playlist (yt-dlp#1488)
  [ceskatelevize] Fix extractor (yt-dlp#1489)
  [youtube] Fix throttling by decrypting n-sig (yt-dlp#1437)
  ...
Lesmiscore added a commit to ytdl-patched/ytdl-patched that referenced this pull request Nov 4, 2021
* 'master' of /~https://github.com/yt-dlp/yt-dlp:
  [Instagram] Improve thumbnail extraction (#1496)
  [cleanup] Minor cleanup
  [ffmpeg] Detect libavformat version for `aac_adtstoasc` and print available features in verbose head Based on ytdl-org/youtube-dl#29581
  [ffmpeg] Accurately detect presence of setts
  [ExtractAudio] Use `libfdk_aac` if available Closes #1502 Authored by: CrypticSignal
  [ffmpeg] Framework for feature detection Related: #1502, #1237, ytdl-org/youtube-dl#29581
  [ExtractAudio] Rescale --audio-quality correctly Authored by: CrypticSignal, pukkandan
atgarcia78 pushed a commit to atgarcia78/yt-dlp that referenced this pull request Nov 14, 2021
@nicolaasjan nicolaasjan mentioned this pull request Feb 7, 2023
11 tasks
@Vangelis66 Vangelis66 mentioned this pull request Apr 29, 2023
3 tasks
@nicolaasjan nicolaasjan mentioned this pull request Jul 19, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is_outdated_version doesn't understand git versions of ffmpeg
1 participant