TST: fix an incompatibility with unyt 3.0 (amu_cgs doesn't exist as a physical constant anymore) #4722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yt-fido test this please |
… physical constant anymore)
neutrinoceros
force-pushed
the
hotfix_amu
branch
from
03a5f3c to
dd96251
Compare
|
Yeah, this needs to be backported. Thanks. |
|
@yt-fido test this please |
1 similar comment
|
@yt-fido test this please |
jzuhone
approved these changes
Nov 1, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/yt
that referenced
this pull request
Nov 1, 2023
…0 (amu_cgs doesn't exist as a physical constant anymore)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix errors in nightly tests seen at /~https://github.com/yt-project/yt/actions/runs/6715141128/job/18249421573
Context: yt-project/unyt#459
running nightly tests again on my fork against this branch at /~https://github.com/neutrinoceros/yt/actions/runs/6721726817
I think this could be backported to yt-4.3.x so we can eventually declare compatibility with unyt 3.0 in a bugfix release.