ENH: fix notebook links #4719
Merged
ENH: fix notebook links #4719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xarthisius
force-pushed
the
issue_4718
branch
5 times, most recently
from
b2abcb4 to
1bc0a36
Compare
chrishavlin
previously approved these changes
Oct 31, 2023
Xarthisius
force-pushed
the
issue_4718
branch
6 times, most recently
from
89d9fa5 to
a1711d0
Compare
Xarthisius
force-pushed
the
issue_4718
branch
from
a1711d0 to
098d22a
Compare
chrishavlin
approved these changes
Nov 1, 2023
|
@matthewturk did you want to look over? or good to merge? |
|
I should have caught up earlier, but does this need to be backported to yt-4.3.x ? |
|
I guess it should, since the bug was affecting stable docs: @meeseeksdev backport to yt-4.3.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/yt
that referenced
this pull request
Nov 3, 2023
neutrinoceros
added a commit
that referenced
this pull request
Nov 4, 2023
…9-on-yt-4.3.x Backport PR #4719 on branch yt-4.3.x (ENH: fix notebook links)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix most of orphaned
.. notebookdirectivesStub
.rstwith just a label and.. notebookare no longer necessary (won't work anyway). In order to link to in TOC use name of the notebook file directly. In order to link within text use`:doc:<relative/path/to/notebook>`... notebook-cellare still not resolved by this PR, but I haven't figured out how to do them (except for using myst and markdown instead).