Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] The f90nml package is *optional* to load RAMSES #4708

Merged
merged 1 commit into from
Oct 19, 2023
Merged

[BUGFIX] The f90nml package is *optional* to load RAMSES #4708

merged 1 commit into from
Oct 19, 2023

Conversation

cphyc
Copy link
Member

@cphyc cphyc commented Oct 19, 2023

The f90nml package is only required to parse the parameter file for RAMSES dataset, but that's not a hard requirement of the RAMSES frontend.

@cphyc cphyc marked this pull request as ready for review October 19, 2023 14:58
@cphyc cphyc added bug code frontends Things related to specific frontends labels Oct 19, 2023
neutrinoceros
neutrinoceros approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@neutrinoceros neutrinoceros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, thanks

@neutrinoceros
Copy link
Member

@yt-fido test this please

1 similar comment
@neutrinoceros
Copy link
Member

@yt-fido test this please

@neutrinoceros neutrinoceros added this to the 4.3.1 milestone Oct 19, 2023
@neutrinoceros
Copy link
Member

@yt-fido test this please

2 similar comments
@neutrinoceros
Copy link
Member

@yt-fido test this please

@neutrinoceros
Copy link
Member

@yt-fido test this please

@neutrinoceros neutrinoceros merged commit 9bd319d into yt-project:main Oct 19, 2023
11 checks passed
@meeseeksmachine meeseeksmachine mentioned this pull request Oct 19, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/yt that referenced this pull request Oct 19, 2023
@neutrinoceros @meeseeksmachine
Backport PR yt-project#4708: [BUGFIX] The f90nml package is *optional…
292ef1d 
…* to load RAMSES
@neutrinoceros neutrinoceros mentioned this pull request Nov 18, 2023
Merged
@cphyc cphyc added the backport-stable on-merge: backport to stable label Mar 5, 2024
@cphyc cphyc deleted the bugfix-ramses-optional-package branch March 5, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neutrinoceros neutrinoceros neutrinoceros approved these changes

Assignees
No one assigned
Labels
backport-stable on-merge: backport to stable bug code frontends Things related to specific frontends
Projects
None yet
Milestone
4.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@cphyc @neutrinoceros