Fix fake_dataset periodicity attribute in FieldDetector #4570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also actually ran into this, but was not certain it was a bug. Nice fix. |
matthewturk
approved these changes
Jul 9, 2023
neutrinoceros
approved these changes
Jul 9, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/yt
that referenced
this pull request
Jul 9, 2023
…n FieldDetector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The
FieldDetectorclass mocks up a fake dataset from adefaultdictif a dataset is not passed. It has to attach a number of basic yt attributes to thisfake_datasetclass, but at the end it tries to use theforce_periodicitymethod, which of course exists on theDatasetclass but not here. I'm just setting the periodicity here by hand, which is the previous behavior and should never have been changed here.I ran into this bug on accident--not sure if it affects anything, but this is the right fix for now until we do something better.
PR Checklist