BUG: Fix off-axis particle projections with a weight field #4482
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The new off-axis particle projections currently fail when a
weight_field
is provided:gives:
The units were not being handled correctly in the augmented division operation. After looking at this, it seems as if we did not need to make the weight field's array a separate
ImageArray
instance since it's just thrown away anyway. This PR simplifies the code and fixes the bug.PR Checklist