Avoiding issue for CHOLLA LightRay datasets #4389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewturk
reviewed
Mar 29, 2023
| @@ -157,6 +157,10 @@ def _is_valid(cls, filename, *args, **kwargs): | |||
| except AttributeError: | |||
| return False | |||
| else: | |||
| return "bounds" in attrs and "domain" in attrs | |||
| # Avoiding issue where CHOLLA LightRay datasets get selected | |||
| if attrs["data_type"] == "yt_light_ray": | |||
There was a problem hiding this comment.
What happens if attrs doesn't have data_type? How about making this part of the below statement, with something like return attrs.get("data_type", None) != "yt_light_ray" or something?
There was a problem hiding this comment.
Good call! I'm not thinking this morning.
neutrinoceros
previously approved these changes
Mar 29, 2023
Co-authored-by: Clément Robert <cr52@protonmail.com>
|
Thanks for the feedback, team! |
neutrinoceros
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CHOLLA frontend identifies its dataset based on the presence of a couple of HDF5 attributes. When a yt
LightRaydataset is created from any frontend, it inherits all of the attributes from that frontend. So when someone tries to load aLightRaydataset created from a CHOLLA frontend, yt gets confused as it thinks it's both a CHOLLA frontend as well as aLightRaydataset and it barfs. This removes that degeneracy by specifically looking for theLightRayattribute in the HDF5 file and not counting it as a CHOLLA dataset when it finds it. Bug reported by @evaneschneider .