boilerplate comment is not mandatory #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and so Severity should be WARNING rather than ERROR
davinci26
added a commit
to davinci26/falco
that referenced
this pull request
Jul 21, 2022
* Add warning for backend health check prober If the backend prober has an initial value that is less than the threshold then when the backend is loaded the initial health checks will not be sufficient to mark it as healthy. As such the backend will be considered unhealthy at startup. I know that it doesnt follow the spec of VCL but it seems valuable to have this imo. Signed-off-by: Sotiris Nanopoulos <sotiris.nanopoulos@reddit.com>
davinci26
added a commit
to davinci26/falco
that referenced
this pull request
Jul 21, 2022
* Add warning for backend health check prober If the backend prober has an initial value that is less than the threshold then when the backend is loaded the initial health checks will not be sufficient to mark it as healthy. As such the backend will be considered unhealthy at startup. I know that it doesnt follow the spec of VCL but it seems valuable to have this imo. Signed-off-by: Sotiris Nanopoulos <sotiris.nanopoulos@reddit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.fastly.com/reference/vcl/subroutines/#concatenation
There are valid use cases to not include Fastly's code macros if it's intended to be concatenated. Therefore, Severity should be WARNING.