Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support --version option #392

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

ronnnnn
Copy link
Contributor

@ronnnnn ronnnnn commented Dec 18, 2024

Overview

  1. Although the output of printHelp included a description of the --version flag1, it was not supported, so I added it.
  2. Since the results of the -V and -h flags generally terminate with exit 0, I modified the exit status accordingly.

Footnotes

  1. /~https://github.com/ysugimoto/falco/blob/8ec8d6b9d3f0f4d68575da2d34ff2dc69c3583b8/cmd/falco/help.go#L65

Copy link
Owner

@ysugimoto ysugimoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Yes the version and help command generally exit with 0, you're right.

@ysugimoto ysugimoto merged commit c5cb984 into ysugimoto:main Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants