Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix psalm issues #334

Merged
merged 9 commits into from
Feb 3, 2024
Merged

Fix psalm issues #334

merged 9 commits into from
Feb 3, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Jan 29, 2024

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Jan 29, 2024

PR Summary

  • Enhanced Column Nullability Checks in DDLQueryBuilder.php
    We've added a logic that determines whether a data column in the database should be marked as "Not Empty" or "Can Stay Empty" based on certain variables. This would ensure data integrity and validity.

  • Improved Unique Constraint Checks in DDLQueryBuilder.php
    Added checks to determine if a certain uniqueness rule (which ensures the data in a column is not repeated) should be applied to a column.

  • Refined Index Creation Method in DDLQueryBuilder.php
    We've updated the method that creates index (a way to speed up the data retrieval) to handle cases where the type of index and indexing method are not defined, providing more robustness to the system.

  • Added Empty Column Verification in DMLQueryBuilder.php
    Implemented a mechanism to verify if the return columns from an action are empty. This aids in ensuring that operations don't proceed on empty data, thus reducing unnecessary computations.

  • Improved Handling of Database Name in Dsn.php
    We've modified the constructor (a special function that initiates an object of a class) to deal seamlessly with situations where the database name is either not defined or just an empty string. This step enhances flexibility and prevents errors linked to non-existent database names.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (02a2a87) 100.00% compared to head (b69ec94) 100.00%.
Report is 1 commits behind head on master.

❗ Current head b69ec94 differs from pull request most recent head 269c63b. Consider uploading reports for the commit 269c63b to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #334   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       241       241           
===========================================
  Files             16        16           
  Lines            694       694           
===========================================
  Hits             694       694           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov added the status:code review The pull request needs review. label Jan 30, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
@vjik vjik merged commit 089f252 into master Feb 3, 2024
31 of 35 checks passed
@vjik vjik deleted the fix-psalm-issues branch February 3, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants