Refactor ArrayExpressionBuilder.php

[Tigrov]

Q	A
Is bugfix?	❌
New feature?	❌
Breaks BC?	❌
Fixed issues	-

[what-the-diff]

PR Summary

• Refactor ArrayExpressionBuilder.php
  This PR features refinements to ArrayExpressionBuilder.php. Import of Traversable was removed and replaced with is_iterable. The build method was slightly altered to utilize ArrayExpression instead of ExpressionInterface, ensuring more specific use.

• Increase Code Encapsulation
  In an effort to enhance the encapsulation and increase the maintainability of the code, the visibility of several methods - buildPlaceholders, getTypeHint, buildSubqueryArray, and typecastValue were changed from protected to private. This adjustment restricts external access to these methods, ensuring they can only be called within the class itself.

• New Test Case for ArrayExpressionBuilder Class
  A new file ArrayExpressionBuilderTest.php was included. This file contains a new test case specifically written for the typecastValue method. This increases the code's test coverage, enabling more reliable and stable features for our end-users.

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (e5de2fc) 99.83% compared to head (6188744) 99.83%.
Report is 2 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #300      +/-   ##
============================================
- Coverage     99.83%   99.83%   -0.01%     
+ Complexity      201      200       -1     
============================================
  Files            13       13              
  Lines           599      596       -3     
============================================
- Hits            598      595       -3     
  Misses            1        1              

Files Changed	Coverage Δ
src/Builder/ArrayExpressionBuilder.php	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[terabytesoftw]

Hi, i really don't like the change, why change the interface for the implementation?

[Tigrov]

Hi, i really don't like the change, why change the interface for the implementation?

It is should be ArrayExpression:
/~https://github.com/yiisoft/db-pgsql/blob/master/src/Builder/ArrayExpressionBuilder.php#L121
/~https://github.com/yiisoft/db-pgsql/blob/master/src/Builder/ArrayExpressionBuilder.php#L129
/~https://github.com/yiisoft/db-pgsql/blob/master/src/Builder/ArrayExpressionBuilder.php#L161

[Tigrov]

And ExpressionInterface does not have getValue() and getType() and getDimension() methods

[vjik]

Need changelog.

[vjik]

@Tigrov Thanks 👍