-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiline default string #295
Conversation
Tigrov
commented
Jul 21, 2023
- Fix multiline default value of string / text
- Fix single quote in default value
Q | A |
---|---|
Is bugfix? | ✔️ |
New feature? | ❌ |
Breaks BC? | ❌ |
Fixed issues | - |
PR Summary
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #295 +/- ##
=========================================
Coverage 99.83% 99.83%
Complexity 202 202
=========================================
Files 13 13
Lines 601 602 +1
=========================================
+ Hits 600 601 +1
Misses 1 1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, add line to changelog
@Tigrov Need test for negative numeric default values whose support has been added by last commit. And add info about it to changelog also. |
Created an issue for adding a test not to block release: #298 |
👍 |