Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update phpTypecast for bool type #291

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Jul 17, 2023

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

@what-the-diff
Copy link

what-the-diff bot commented Jul 17, 2023

PR Summary

  • Simplification of Boolean Typecast Logic in ColumnSchema.php
    The logic for typecasting to boolean in the phpTypecastValue method has been streamlined. The update specifically refines the condition to check if the value is considered true, disregarding specific character 'f'. This modification should improve the readability of the code and potentially increase program efficiency.

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (60e64e0) 99.67% compared to head (479f6a8) 99.66%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #291      +/-   ##
============================================
- Coverage     99.67%   99.66%   -0.01%     
- Complexity      203      204       +1     
============================================
  Files            13       13              
  Lines           609      604       -5     
============================================
- Hits            607      602       -5     
  Misses            2        2              
Impacted Files Coverage Δ
src/ColumnSchema.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Tigrov Tigrov marked this pull request as ready for review July 17, 2023 09:26
@samdark samdark requested review from darkdef and terabytesoftw July 18, 2023 13:38
@terabytesoftw
Copy link
Member

terabytesoftw commented Jul 19, 2023

@Tigrov

Hi, please add changelog line,

Do you have any other improvement in mind, except to release all the db packages.

Thks,

@Tigrov
Copy link
Member Author

Tigrov commented Jul 19, 2023

@terabytesoftw

Hi. There are several minor changes. And a couple that will take time.
I will try to push the minor changes until the end of the week.

Thanks.

@terabytesoftw
Copy link
Member

@terabytesoftw

Hi. There are several minor changes. And a couple that will take time. I will try to push the minor changes until the end of the week.

Thanks.

thks

@terabytesoftw terabytesoftw merged commit 7c402ef into yiisoft:master Jul 19, 2023
@Tigrov Tigrov deleted the update_bool_cast branch July 20, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants