Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dashed custom tag names #546

Merged
merged 3 commits into from
Jul 31, 2019
Merged

Support dashed custom tag names #546

merged 3 commits into from
Jul 31, 2019

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented Jul 30, 2019

Fixes #193

@jstarry jstarry mentioned this pull request Jul 30, 2019
Closed
@jstarry
Copy link
Member Author

jstarry commented Jul 30, 2019

@totorigolo would you mind looking over this PR? 😄

totorigolo
totorigolo reviewed Jul 30, 2019
View reviewed changes
Copy link
Contributor

@totorigolo totorigolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we go 🙂

tests/macro/html-tag-pass.rs Outdated Show resolved Hide resolved
crates/macro/src/html_tree/html_tag/mod.rs Outdated Show resolved Hide resolved
crates/macro/src/html_tree/html_tag/mod.rs Outdated Show resolved Hide resolved
crates/macro/src/html_tree/html_dashed_name.rs Show resolved Hide resolved
@jstarry
Copy link
Member Author

jstarry commented Jul 31, 2019

Thanks @totorigolo!

@jstarry
Copy link
Member Author

jstarry commented Jul 31, 2019

bors r+

bors bot added a commit that referenced this pull request Jul 31, 2019
@bors @jstarry
Merge #546
af9d05b 
546: Support dashed custom tag names r=jstarry a=jstarry

Fixes #193

Co-authored-by: Justin Starry <jstarry@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Jul 31, 2019

Build succeeded

@bors bors bot merged commit f2e0f48 into master Jul 31, 2019
@jstarry jstarry deleted the dashed-tag-names branch August 3, 2019 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@totorigolo totorigolo totorigolo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Macro fails with custom HTML tags that have dashes
2 participants
@jstarry @totorigolo