-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#3129) Fix incorrect text escaping during SSR #3381
Conversation
Visit the preview URL for this PR (updated for commit 9949e9f): https://yew-rs-api--pr3381-fix-ssr-html-escapin-l9hdwp9l.web.app (expires Mon, 28 Aug 2023 12:15:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Size Comparison
✅ None of the examples has changed their size significantly. |
Benchmark - SSRYew Master
Pull Request
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the PR! I took a cursory look and it looks mostly good to me. Just a few comments
Can you also add a test case for the multi vtext node example I mentioned in #3129 (comment)
packages/yew/src/server_renderer.rs
Outdated
/// Right now this is used to make `VText` nodes aware of their environment and correctly | ||
/// escape their contents when rendering them during SSR. | ||
#[derive(Default, Clone, Copy)] | ||
pub(crate) enum SpecialVTagKind { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pub(crate) enum SpecialVTagKind { | |
pub(crate) enum VTagKind { |
I think it is better to name this as VTagKind as the Other
variant is not special.
Wait why did it think the current user is github-actions...? |
Description
Fixes #3129
Checklist