-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Context: cleanup - avoid storing a copy of children #2885
Context: cleanup - avoid storing a copy of children #2885
Conversation
The new changed() signature allows accessing old_props, so there is no more need to store an additional copy of children.
Visit the preview URL for this PR (updated for commit 5dbc933): https://yew-rs-api--pr2885-cleanup-context-prov-v4so9qbh.web.app (expires Sun, 02 Oct 2022 07:36:23 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - SSRYew Master
Pull Request
|
Size Comparison
✅ None of the examples has changed their size significantly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request also slightly reduces the bundle size.
Thank you for the pull request. LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Looks good to me
The new changed() signature allows accessing old_props, so there is no more need to store an additional copy of children.