Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed pub_sub link to point to correct example #2332

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

tnyjhnsn
Copy link
Contributor

@tnyjhnsn tnyjhnsn commented Jan 6, 2022

Description

The pub_sub example in the docs linked to the master branch, rather than the versioned branch, and resulted in a 404. This new link points to the pub_sub example for Version 0.19.3

Fixes #2323

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • I have added tests

Copy link
Member

@voidpumpkin voidpumpkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@github-actions
Copy link

github-actions bot commented Jan 6, 2022

Visit the preview URL for this PR (updated for commit 1ed26bd):

https://yew-rs--pr2332-fix-pub-sub-example-bt8vbe6q.web.app

(expires Thu, 13 Jan 2022 07:58:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@ranile ranile added the blocked label Jan 6, 2022
@ranile
Copy link
Member

ranile commented Jan 6, 2022

Blocked by #2334

@ranile ranile added this to the v0.20 milestone Jan 6, 2022
@ranile ranile removed the blocked label Jan 6, 2022
@ranile
Copy link
Member

ranile commented Jan 6, 2022

Please merge master into this
That shouldn't matter

@ranile ranile merged commit 76010d1 into yewstack:master Jan 6, 2022
@tnyjhnsn tnyjhnsn deleted the fix-pub_sub-example-link branch January 6, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example links on versioned website docs link to master
3 participants