Remove Drop bound from Task trait #1627
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rust now emits a warning for
Drop
bounds. This PR simply removes it from theTask
trait and updates the documentation. A type implementingTask
doesn't necessarily need to implementDrop
itself to fulfil the invariant. Especially withweb-sys
/glee
types that already clean up when dropped there's no need for the task itself to implementDrop
as well.I also removed the long redundant
to_ms
function and made it so the methods panic instead of truncating whenduration
is too big. This technically makes this a breaking change but I'm 99% sure that no one is currently relying on this behaviour :DChecklist
cargo make pr-flow