Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

read.xlsx() can no longer parse .xlsm files #209

Closed
dseynaev opened this issue Jun 29, 2021 · 3 comments
Closed

read.xlsx() can no longer parse .xlsm files #209

dseynaev opened this issue Jun 29, 2021 · 3 comments
Labels
fixed Fixed, issue will be closed within 7 days

Comments

@dseynaev
Copy link
Contributor

dseynaev commented Jun 29, 2021 •
edited
Loading

we were using openxlsx 4.2.3 before and successfully parsing .xlsm files with read.xlsx

in 4.2.4 we see:

openxlsx can only read .xlsx files

my guess is this was introduced here:
86070be#diff-43a394a441eb434c8b24866cf52453aa6dbca568a67a60e98d08ebaab8124603L119-L121

is it intended for read.xlsx to not support .xlsm? or was the regex pattern improperly generalized?
@JanMarvin
Copy link
Collaborator

Hi @dseynaev , the change was most likely unintended. Could you create a pull request to modify this regex?

@dseynaev dseynaev mentioned this issue Jun 29, 2021
Merged
ycphs added a commit that referenced this issue Jun 29, 2021
@ycphs
Merge pull request #210 from dseynaev/patch_read_xlsx_regex
472c27d 
fix: extend regex in read.xlsx to allow .xlsm files; solves #209
@ycphs ycphs added the fixed Fixed, issue will be closed within 7 days label Jun 30, 2021
@ycphs
Copy link
Owner

ycphs commented Jul 1, 2021

I think we can close the issue

@ycphs ycphs closed this as completed Jul 1, 2021
@jormercury
Copy link

Thanks for fixing this, I had to instruct several people to downgrade to 4.2.3. Is it possible to release a stable version with this fix soon? It seems to me like a simple fix, but with large consequences for anyone trying to read in xlsm files using openxlsx.

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Jan 4, 2025
(textproc/R-openxlsx) Updated 4.2.4 to 4.2.7.1
a91df5a 
# openxlsx 4.2.7.1

* It's now possible to insert a hyperlinked image by passing a URL,
  relative or absolute file path, or mailto string to the new
  `address` parameter of `insertImage()`.

# openxlsx 4.2.7

* Fixed warning on `dataValidation(..., type = "list")`
  ([#342](ycphs/openxlsx#342))

* Added optional argument to `loadWorkbook` to decide if empty/blank
  cells should be converted to NA_character_ (the default) or left
  blank as is

* `saveWorkbook()` now succeeds when called after the user has set
  column widths for a range of columns (e.g. 1:2), saved the workbook,
  then set column widths for a new range that is inclusive of the
  previous one (e.g. 1:5)
  ([#493](ycphs/openxlsx#493)).

## Improvements

* Improve detectDates
  ([#288](ycphs/openxlsx#288))

* Preserve window size and position, also `getWindowSize()` and
  `setWindowSize()`
  ([466](ycphs/openxlsx#466))

# openxlsx 4.2.6

* Fix external links
  ([#410](ycphs/openxlsx#410))

* Do not add unneccessary sheetPr node
  ([#409](ycphs/openxlsx#409))

* Add support for `namedRegion`s having dots and other special
  characters ([#338](ycphs/openxlsx#338)).

* Add type blanks and not blanks to conditional formatting
  ([#311](ycphs/openxlsx#311))

# openxlsx 4.2.5

## Fixes

* `openxlsx_setOp()` now works with named list
  ([#215](ycphs/openxlsx#215))

* `loadWorkbook()` imports `inlineStr`. Values remain `inlineStr` when
  writing the workbook with `saveWorkbook()`. Similar `read.xlsx` and
  `readWorkbook` import `inlineStr`.

* `read.xlsx()` no longer changes random seed
  ([#183](ycphs/openxlsx#183))

* fixed a regression that caused fonts to be read in incorrectly
  ([#207](ycphs/openxlsx#207))

* add option to save as read only recommended
  ([#201](ycphs/openxlsx#201))

* fixed writing hyperlink formulas
  ([#200](ycphs/openxlsx#200))

* `write.xlsx()` now throws an error if it doesn't have write
  permissions ([#190](ycphs/openxlsx#190))

* `write.xlsx()` now again uses the default of `overwrite = TRUE` for
  saving files ([#249](ycphs/openxlsx#249))

* `as.character.formula()` exported to warn about potential conflicts
  with other packages
  ([#312](ycphs/openxlsx#312),
  [#315](ycphs/openxlsx#315))

## Improvements

* `options()` are more consistently set in functions (see:
  [#289](ycphs/openxlsx#262))

* `Workbook$show()` no longer fails when called in a 0 sheet
  workbook([#240](ycphs/openxlsx#240))

* `read.xlsx()` again accepts `.xlsm` files
([#205](ycphs/openxlsx#205),
[#209](ycphs/openxlsx#209))

* `makeHyperlinkString()` does no longer require a sheet argument
  ([#57](ycphs/openxlsx#57),
  [#58](ycphs/openxlsx#58))

* improvements in how `openxlsx` creates temporary directories (see
  [#262](ycphs/openxlsx#262))

* `writeData()` calls `force(x)` to evaluate the object before options
  are set ([#264](ycphs/openxlsx#264))

* `createComment()` now correctly handles `integers` in `width` and
  `height` ([#275](ycphs/openxlsx#275))

* `setStyles()` accepts `halign="justify"`
  ([#305](ycphs/openxlsx#305))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed Fixed, issue will be closed within 7 days
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JanMarvin @dseynaev @jormercury @ycphs