Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Windows and MacOS #36

Merged
merged 7 commits into from
Sep 2, 2021
Merged

Support Windows and MacOS #36

merged 7 commits into from
Sep 2, 2021

Conversation

Kludex
Copy link
Collaborator

@Kludex Kludex commented Sep 1, 2021

Closes #32

Changes

  • Replace bullet by questionary.
  • Add windows-latest and macos-latest on the CI.
  • Remove interactive test. I was not able to make it work, and I'll not spend more time on it.

@Kludex Kludex marked this pull request as draft September 1, 2021 22:38
@Kludex Kludex marked this pull request as ready for review September 2, 2021 18:53
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2021

Codecov Report

Merging #36 (b70414c) into master (91c9783) will decrease coverage by 2.63%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
- Coverage   86.20%   83.57%   -2.64%     
==========================================
  Files           7        7              
  Lines         145      140       -5     
==========================================
- Hits          125      117       -8     
- Misses         20       23       +3     
Impacted Files Coverage Δ
manage_fastapi/helpers.py 63.63% <66.66%> (-18.72%) ⬇️
manage_fastapi/main.py 72.97% <66.66%> (-4.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91c9783...b70414c. Read the comment docs.

@Kludex
Copy link
Collaborator Author

Kludex commented Sep 2, 2021

I know @codecov-commenter, and I'm really sorry. 😰

@Kludex Kludex requested a review from ycd September 2, 2021 18:59
@Kludex
Copy link
Collaborator Author

Kludex commented Sep 2, 2021

@ycd Please check if you're willing to lose that coverage, or if you want to check the issue. 😗

@ycd
Copy link
Owner

ycd commented Sep 2, 2021

Awesome! I thought support for Windows would be more complicated!

%2 coverage loss ?

🙈 😄

@Kludex Kludex merged commit 41648fb into master Sep 2, 2021
@Kludex Kludex mentioned this pull request Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error during startproject [ ModuleNotFoundError: No module named 'termios' ]
3 participants