-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Widget: MenuBar (UI Interpreter Part) #53
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shundhammer
changed the title
WIP: New Widget: MenuBar (UI Interpreter Part
WIP: New Widget: MenuBar (UI Interpreter Part)
Jul 13, 2020
This was referenced Jul 15, 2020
wfeldt
approved these changes
Jul 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
❌ Public Jenkins job #20 failed |
❌ Internal Jenkins job #19 failed |
❌ Internal Jenkins job #20 failed |
shundhammer
changed the title
WIP: New Widget: MenuBar (UI Interpreter Part)
New Widget: MenuBar (UI Interpreter Part)
Aug 12, 2020
✔️ Internal Jenkins job #21 successfully finished |
✔️ Public Jenkins job #21 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello
https://trello.com/c/4GtDpmMo/
Bugzilla
https://bugzilla.opensuse.org/show_bug.cgi?id=1175115
Overview
This adds the MenuBar widget to the UI interpreter.
For more details, see the main PR for this feature:
/~https://github.com/libyui/libyui/pull/169
Travis Build Failure
This doesn't build because the image used by Travis does not yet contain the libyui with the new features. This is expected.
Related PRs