chore(xod-client-browser): replace DOUBLE_TAP deploy with appending commit offset to Docker image tags
#674
Conversation
alexander-matsievsky
force-pushed
the
feat-673-replace-double-tap-deploy-with-appending-commit-hash-to-docker-image-tags
branch
from
2f4d56a to
aac9621
Compare
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "xod-client-browser", | |||
| "version": "0.11.0-dev", | |||
| "version": "0.11.0", | |||
There was a problem hiding this comment.
We’re not ready to 0.11.0 yet. Use 0.11.0-dev.2 or something
|
@nkrkv ok? |
1 similar comment
|
@nkrkv ok? |
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "xod-client-browser", | |||
| "version": "0.11.0-dev", | |||
| "version": "0.11.0-dev.2", | |||
There was a problem hiding this comment.
Sorry for raising the topic again. I totally forget that lerna should be used to bump versions in the repo. We should not bump individually and by hand. At last, we’re learning, isn’t it?
BTW, is there a real reason we should bump it now. Will we lose anything if you’ll just keep it 0.11.0-dev as it was?
| echo 'xodio/ide' >IMAGE_NAME | ||
| node -p 'require("./package.json").version' >VERSION | ||
| node -p "require('./package.json').version + '-$HASH'" >VERSION |
There was a problem hiding this comment.
According to the semver spec, we should really use + here. Otherwise, the versions pretend to be sortable.
E.g.
0.10.0-abcd
0.10.0-bcde
0.10.0-cdef
chronology is implied although it can differ in fact.
There was a problem hiding this comment.
@nkrkv https://docs.docker.com/engine/reference/commandline/tag/#extended-description
A tag name must be valid ASCII and may contain lowercase and uppercase letters, digits, underscores, periods and dashes. A tag name may not start with a period or a dash and may contain a maximum of 128 characters.
There was a problem hiding this comment.
@nkrkv The + sign was used initially, which errored.
There was a problem hiding this comment.
OK. To keep things ordered, can we use git describe --tags in this case?
$ git describe --tags
v0.11.0-dev-14-gdeb0fc2e
14 is what would make subversioning linear.
There was a problem hiding this comment.
@nkrkv Ordered where? Docker Hub sorts chronologically, not lexicographically. https://hub.docker.com/r/library/node/tags/
There was a problem hiding this comment.
Not a big deal, but I find:
0.11.0-0
0.11.0-7
0.11.0-9
much easier to follow in mind than:
0.11.0-deb0fc2
0.11.0-0383abb
0.11.0-6675eaf
Bonus: it doesn’t violate semver spec.
alexander-matsievsky
force-pushed
the
feat-673-replace-double-tap-deploy-with-appending-commit-hash-to-docker-image-tags
branch
from
47fbe72 to
1cec84b
Compare
alexander-matsievsky
changed the title
DOUBLE_TAP deploy with appending commit hash to Docker image tagsDOUBLE_TAP deploy with appending commit hash to Docker image tags
|
@nkrkv ok? |
… commit offset to Docker image tags
alexander-matsievsky
force-pushed
the
feat-673-replace-double-tap-deploy-with-appending-commit-hash-to-docker-image-tags
branch
from
47c5b6c to
171f25c
Compare
alexander-matsievsky
changed the title
DOUBLE_TAP deploy with appending commit hash to Docker image tagsDOUBLE_TAP deploy with appending commit offset to Docker image tags
|
@nkrkv ok? |
|
Cool 🎉 LGTM |
alexander-matsievsky
deleted the
feat-673-replace-double-tap-deploy-with-appending-commit-hash-to-docker-image-tags
branch
Closes #673.