Fix dirtyness propagation optimization to work fine with tweaks

[brusherru]

It fixes #2047

The bug was introduced in the 0.33.0 right in the commit 0880f41 😬

[nkrkv]

Wouldn’t it be more appropriate to move this business logic out of the template, to the helper definitions or even further? Templates are harder to maintain.

[evgenykochetkov]

If I understand #2047 correctly, the following is happening:

digital-write node that wants to update only when UPD pin is touched, as stated by

#pragma XOD evaluate_on_pin disable
#pragma XOD evaluate_on_pin enable input_UPD

but the code generated in handleDebugProtocolMessages

xod/packages/xod-arduino/platform/program.tpl.cpp

Lines 149 to 150 in faf25a8

	g_transaction.node_{{ id }}_isNodeDirty = true;
	g_transaction.node_{{ id }}_isOutputDirty_OUT = true;

(and maybe in some other place?) does not respect that.

I think that forcing generation of node_NNN_isOutputDirty_XXX and marking nodes as dirty in such situation is not right. The role of tweak node connected to pin with evaluate_on_pin disabled should be reduced to just storing the received value, and marking the pin and node dirty should be skipped.

[brusherru]

@nkrkv @evgenykochetkov check it out again, please :)

[evgenykochetkov]

LGTM👍🏻

[nkrkv]

👍