Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix label margins to fit labels with four characters #1420

Merged
merged 1 commit into from
Aug 21, 2018

Conversation

brusherru
Copy link
Contributor

It fixes #1417.
But one important thing, without margins at all it still not fit "WWWW" 😬

@brusherru brusherru self-assigned this Aug 20, 2018
@brusherru brusherru requested a review from a team August 20, 2018 17:56
@brusherru brusherru force-pushed the fix-1417-four-character-labels branch from c9c0ad5 to f69a1e7 Compare August 20, 2018 17:57
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Prior to merge, rebase properly so that changes from patchSearchData.js are not a part of this commit.

@brusherru brusherru changed the base branch from master to 0.23.x August 21, 2018 09:39
@brusherru brusherru merged commit f08d395 into 0.23.x Aug 21, 2018
@brusherru brusherru deleted the fix-1417-four-character-labels branch August 21, 2018 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants