Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More consistent snackbar messages #1330

Merged
merged 1 commit into from
Jul 6, 2018
Merged

More consistent snackbar messages #1330

merged 1 commit into from
Jul 6, 2018

Conversation

nkrkv
Copy link
Member

@nkrkv nkrkv commented Jul 5, 2018

Closes #955

@nkrkv nkrkv requested a review from a team July 5, 2018 15:46
evgenykochetkov
evgenykochetkov approved these changes Jul 5, 2018
View reviewed changes
Copy link
Contributor

@evgenykochetkov evgenykochetkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/xod-client/src/project/messages.js
title: 'Canʼt create link',
note: 'Unknown error!',
persistent: false,
title: 'No-no-no',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@nkrkv nkrkv force-pushed the tweak-955-headlinese-messages branch from ed7457f to c9af6fa Compare July 5, 2018 16:12
@nkrkv nkrkv force-pushed the tweak-955-headlinese-messages branch from c9af6fa to d0d8b80 Compare July 6, 2018 08:35
@nkrkv nkrkv merged commit c609083 into master Jul 6, 2018
@nkrkv nkrkv deleted the tweak-955-headlinese-messages branch July 6, 2018 08:52
@nkrkv nkrkv mentioned this pull request Jul 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgenykochetkov evgenykochetkov evgenykochetkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkrkv @evgenykochetkov