Make snack bar messages persistent by default #1284
Merged
+81
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brusherru
force-pushed
the
tweak-1234-persistent-messages-by-default
branch
from
20c31bc to
2ca94ce
Compare
| type: ActionType.MESSAGE_ADD, | ||
| payload: messageData, | ||
| meta: { | ||
| id, | ||
| type, | ||
| persistent, | ||
| persistent: R.propOr(true, 'persistent', messageData), |
There was a problem hiding this comment.
Could it default to true only if type is MESSAGE_TYPE.ERROR?
There was a problem hiding this comment.
I thought about it and even did it at first. But when I began to place persistent flags in message objects, I realized that there is confusion. So I decided to do it persistent by default for all types of messages.
brusherru
force-pushed
the
tweak-1234-persistent-messages-by-default
branch
2 times, most recently
from
c486678 to
650723c
Compare
|
@nkrkv @evgenykochetkov just fixed it. Check it out, please. |
| persistent = false, | ||
| id = null | ||
| ) => ({ | ||
| const getDefaultPersistencyByType = type => { |
There was a problem hiding this comment.
why not just const getDefaultPersistencyByType = R.equals(MESSAGE_TYPE.ERROR)?
evgenykochetkov
approved these changes
Jun 14, 2018
nkrkv
requested changes
Jun 14, 2018
| case MESSAGE_TYPE.CONFIRMATION: | ||
| case MESSAGE_TYPE.NOTIFICATION: | ||
| default: | ||
| return false; |
There was a problem hiding this comment.
The whole function can be simplified to type === MESSAGE_TYPE.ERROR.
brusherru
force-pushed
the
tweak-1234-persistent-messages-by-default
branch
from
650723c to
bf2d9ff
Compare
|
My bad 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It closes #1234