Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mobile): hand tracking model with drawing #6

Merged
merged 8 commits into from
Jul 4, 2024

Conversation

nicolantean
Copy link
Collaborator

⭐ Feature


✏️ Description:

Added logic for TensorFlow lite models support and the hand tracking model—also, Some widgets for the drawing of the hand on the screen.


🎥 Screen record:

iOS

RPReplay_Final1718818624.mov

📌 Notes:

  • The hand position on the drawing is still not accurate at all, there are some minor errors with the padding.
  • The performance is not as good as expected yet.

@nicolantean nicolantean requested review from fedecor9 and mirland June 19, 2024 17:42
@mirland
Copy link
Contributor

mirland commented Jun 19, 2024

Add a couple of task in the backlog, one to fix the points and the other tho improve the performance

Copy link
Collaborator

@fedecor9 fedecor9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@mirland mirland changed the title feat: hand tracking model with drawing feat(mobile): hand tracking model with drawing Jun 19, 2024
@nicolantean nicolantean requested review from mirland and fedecor9 June 20, 2024 19:21
@fedecor9 fedecor9 mentioned this pull request Jun 27, 2024

static Future<void> saveImage(img.Image image, [int i = 0]) async {
final jpeg = img.encodeJpg(image);
final appDir = await getTemporaryDirectory();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Path provider is not supported in web, now it's not a problem but if we want to implement a web app we might need to create a custom interface for this use cases.
Not a comment to fix right now, just something to keep in mind for later

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, we can discuss it, and check if we need this function for the app or not

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I think we don't need it


static Future<void> saveImage(img.Image image, [int i = 0]) async {
final jpeg = img.encodeJpg(image);
final appDir = await getTemporaryDirectory();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I think we don't need it

@nicolantean nicolantean merged commit 3d93228 into main Jul 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants