Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor game logic #25

Merged
merged 8 commits into from
Sep 19, 2024
Merged

chore: Refactor game logic #25

merged 8 commits into from
Sep 19, 2024

Conversation

mirland
Copy link
Contributor

@mirland mirland commented Sep 17, 2024

♻️ Refactor

✏️ Description:

  • The cubit manages a lot of stream that doesn't make sense, so I move that stream to the game manager
  • I used transformers to handle the app logic

@nicolantean nicolantean self-requested a review September 18, 2024 21:41
Copy link
Collaborator

@nicolantean nicolantean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Comment on lines 27 to 33
final previousSequencePoints =
(((gameSequence.length - 1) * gameSequence.length / 2) *
_pointForSuccess)
.toInt();
final actualSequencePoints =
(currentSequence.length - 1) * _pointForSuccess;
final currentPoints = previousSequencePoints + actualSequencePoints;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

method?

currentSequence[gameSequence.indexOf(gesture)].gesture,
);

int _gamePints(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@mirland mirland merged commit b160729 into main Sep 19, 2024
1 check passed
@mirland mirland deleted the feat/game-refactor branch September 19, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants