Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log_interval 5 #2

Merged
merged 1 commit into from
Feb 5, 2021
Merged

log_interval 5 #2

merged 1 commit into from
Feb 5, 2021

Conversation

jaimepedretp
Copy link
Collaborator

log_interval 10 to 5

@@ -11,7 +11,7 @@
'num_episodes': 1250, # Number of training episodes
'lr': 1e-2, # Learning rate
'gamma': 0.99, # Discount rate
'log_interval': 10, # controls how often we log progress
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like odd numbers, but I'll accept it anyway

Copy link
Collaborator

@eldarsilver eldarsilver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seal of approval!!

Copy link
Owner

@xeviknal xeviknal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this. This is tooo small.

Copy link
Collaborator

@ziritrion ziritrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test it, my dog ate my laptop

Copy link
Owner

@xeviknal xeviknal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. I do prefer to see updates quite more often.

Copy link
Collaborator

@ziritrion ziritrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I punched my dog and he puked my laptop. I tested it and I am now a millionare. I approve.

@xeviknal
Copy link
Owner

xeviknal commented Feb 5, 2021

selfie-0

@ziritrion
Copy link
Collaborator

I push the green button ^_^

@ziritrion ziritrion merged commit 3635b91 into main Feb 5, 2021
@ziritrion ziritrion deleted the with-baseline branch February 5, 2021 17:55
ziritrion added a commit that referenced this pull request Apr 5, 2021
ziritrion added a commit that referenced this pull request Apr 13, 2021
xeviknal added a commit that referenced this pull request Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants