-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to 3.39.2 #746
Upgrade to 3.39.2 #746
Conversation
Saw this in the release notes:
We can probably remove this: Line 81 in ada2b14
|
I see there is an updated binary for Mac aarch64, just wanted to check, did you compile that on your M1 mac @pyckle ? |
The build is failing on armv7 and aarch64. Just to be sure i compared with a recent build from the current master, and those work, so this must be because of the new changes in this PR. We need to find out why this happens with this PR. |
This is weird that is needs a version of Glibc that is very recent. Dockcross should have |
I see |
The M1 build was built on my M1 Mac. It was tested. I just moved armv7a to lts, and that should only requires glibc 2.28+ according to the dockcross docs. I will make the same change for aarch64 and get that pushed shortly. I will also remove the JSON build def, and rebuilt all other binaries. |
Awesome, I was not sure you had an M1.
I think we should use all the available lts to avoid issues. |
66ae2e6
to
2625ffd
Compare
arm64 is now moved to lts, and new binaries are pushed I will do it with the rest of the archs in the next couple of days. If the lts toolchains don't make the build pass, we'll have to hardcode an older version of the dockcross docker images. |
Actually, the lts versions are only for arm and mips. All arm builds were moved to lts, and we don't build for mips. So I think this should be good, unless you'd like me to cleanup the commit log/squash things. |
I will squash on merge, don't worry. Will review tomorrow 👍🏻 |
No description provided.