Build multiplatform docker image #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build arm64 image in addition to the already setup amd64 platform
i've tested the workflow in my fork /~https://github.com/an-tex/eck-custom-resources/actions/runs/4937194206/jobs/8825667024 by pushing to my own docker repo https://hub.docker.com/r/antex/eck-custom-resources/tags and deploying into my arm64 cluster. the operator came up just fine :) i've tested the amd64 image on my local machine just to be sure we still build that too ;)
for more background around the Dockerfile changes https://www.docker.com/blog/faster-multi-platform-builds-dockerfile-cross-compilation-guide/
while a was it it i've update the github action versions in the docker-publish workflow.