This repository has been archived by the owner on May 1, 2024. It is now read-only.
[iOS] Add missing call to ReloadData on NotifyCollectionChangedAction.Reset #6089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartez
added
the
DO-NOT-MERGE-!!! 🛑
|
Adding and DNM for the moment - I want to add a UI test so we can make sure this doesn't pop up again. |
hartez
removed
the
DO-NOT-MERGE-!!! 🛑
rmarinho
approved these changes
May 7, 2019
paymicro
approved these changes
May 8, 2019
rmarinho
reviewed
May 12, 2019
| @@ -59,6 +59,7 @@ void CollectionChanged(object sender, NotifyCollectionChangedEventArgs args) | |||
| Move(args); | |||
| break; | |||
| case NotifyCollectionChangedAction.Reset: | |||
| _collectionView.ReloadData(); | |||
There was a problem hiding this comment.
Still not working..
XF Version = 4.8.0.1687
|
Still not working.. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The iOS adapter for INotifyCollectionChanged is missing a call to
ReloadDatawhen handlingNotifyCollectionChangedAction.Reset. This adds the missing call.Issues Resolved
API Changes
None
Platforms Affected