Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Add workaround for bugzilla 37792 #181

Merged
merged 1 commit into from
Jul 19, 2016
Merged

Add workaround for bugzilla 37792 #181

merged 1 commit into from
Jul 19, 2016

Conversation

Costo
Copy link
Contributor

@Costo Costo commented May 16, 2016 •
edited by samhouts
Loading

Description of Change

Catch an ObjectDisposedException in Image.cs. This is causing lots of crashes in production for us, but we are not able to reproduce the bug reliably.

Bugs Fixed

https://bugzilla.xamarin.com/show_bug.cgi?id=37792

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@dnfclas
Copy link

dnfclas commented May 16, 2016

Hi @Costo, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

@Costo
Copy link
Contributor Author

Costo commented May 17, 2016

The only way to fix this problem currently is to copy/paste the code for the Image control and its renderers in our project in order to modify the Image.OnSourcePropertyChanging method.
If the solution proposed in this PR is not acceptable, there are alternative ways, like:

  • Unseal the *ImageSource classes. This way we could inherit from them and override the Cancel method
  • Change accessibility of Image.OnSourcePropertyChanging(ImageSource oldvalue, ImageSource newvalue) to protected. This way we could inherit from Image and override OnSourcePropertyChanging.

@rmarinho
Copy link
Member

rmarinho commented Jun 8, 2016

👍

1 similar comment
@jassmith
Copy link

👍

@jassmith jassmith merged commit 28d9e8a into xamarin:master Jul 19, 2016
@samhouts samhouts added this to the 2.3.2 milestone Jun 27, 2018
mattleibow pushed a commit that referenced this pull request Jan 28, 2021
@moljac @jamesmontemagno
GH-12 Text To Speech initial version (#181)
475b097 
* initial commit

* merge with master

* Tests and missing method copied from the branch

* Android text splitting fixes

* awaitable Initialization methods

* Android reworked - initialize and speak in single method

* removed tweaks for work on Mac and garbage VS4Mac added

* uwp parameters done

* Android TTS with parameters

* TTS iOS parameters

* Refactor TTS code

- Simplify implementations
- Implement remaining pitch/speakrate/volume normalizations
- Implement cancel token logic
- Refact to use public api in shared.cs and platform invocations in platformname.cs

* Adjust slider ranges to match max/min settings

* Simplify TTS demo text

* Move enums into TextToSpeech

Don't really want Pitch, Volume, and SpeakRate enums to be at the root namespace level, so moved them into TextToSpeech.

* Fix sln folders

* Added docs for Text to Speech

* Clean up pitch/volume/speak rate and normalization

* Make 1.0 volume default in tts sample

* Removed accidental / invalid enum value

* Cleanup iOS and UWP apis to queue up message. Added samples to do multiple lines of text queued. Refactored how we throw exceptions.

* A few changes to the API
 - removed redundant code
 - removed enums

* Use TaskCompletionSource<bool> instead of <object>

* Updated docs

* Removing unnecessary changes

* Reverting some changes

* Cleanup random object in tcs.

* cleanup tcs on iOS

* Re-use semaphoreslim :) bring things local if possible

* Fixup uwp, remove the accidental semaphore await.

* Add sample to pick locale

* Additioanl cleanup, use whenall

* Remove speak rate for now

* Remove speakrate from docs

* Fix UWP locales

* Fix up android dispose issues :)

* Remove the dispose calls around TTS

* Fix up splitting of strings and add tests.

* Cancel the speech when leaving the page

* Fix android locale's so it speaks back correctly :)
mattleibow pushed a commit that referenced this pull request Jan 28, 2021
@jamesmontemagno @Redth
Fixes #181 Allowing setting of calibration for heading. (#282)
a44fdb4
mattleibow pushed a commit that referenced this pull request Jan 28, 2021
@jamesmontemagno
Merge master into main (#308)
a09a031 
* GH-221: Add iOS SecAccessible properties (#223)

* Address #221, use AfterFirstUnlockThisDeviceOnly to match other platforms. Although allow a platform specific override to set accessible state.

* Add tests

* Added iOS specific prop to set SecAccessible

* Default to AfterFirstUnlock on iOS SecureStorage

* A few fixes for the release. (#228)

* Setting the correct flags for Chrome Tabs. Fixes #225

* Make sure that there is data to decrypt before starting. Fixes #226

* Fixes for TTS. Fixes #227

* A bit of the fixes for emails on iOS. Relates to #224

* Update the email bit for iOS #224

* Cleaning up the code #224

* Make sure to set the email properties. Fixes #229

* Update SDK Extras

This fixes a lot of references that were required on android that aren't.

* Update Readme with Installation information. (#237)

* Update Readme with Installation information.

* Update README.md

* Update README.md

* Adding the initial work to get Tizen started. #23

* Revert "Adding the initial work to get Tizen started. #23"

This reverts commit 58b6041.

* Update the docs with the latest APIs (#233)

Add docs for SecAccessible

* GH-245: Add Orientation Sensor (#249)

* Add Orientation Sensor

* Add Orientation Sensor

* Remove .csproj clutter

* "orientationsensor" --> "orientation sensor" or just "orientation"

* GH-192: Added DateTime to Preferences (#232)

* Added DateTime to preferences. Fixes #192
 - also properly using overloads

* Added some unit tests

* Added the docs for the new Preferences APIs

* Update Readme with Device Display Information

Added link to Current Features for Device Display Information

* Fixes #258 and Fixes #255 (#259)

* Fixes #258
* put vectors nuget everywhere.
* NuGet is broken - https://developercommunity.visualstudio.com/content/problem/232996/warning-nu1603-runtimenativesystemiocompression-41.html
* The NuGet doesn't add the assembly references from the GAC
* We need to use a later version of the iOS SDK

* Fix typo (#274)

* Fix up null checks when getting lask known location.

* Additional Null checks

* GH-240 Add IsMainThread detection API (#277)

* Add IsMainThread detection API

* Add platform tests for main thread

* Update docs and add more platform tests

* iOS secure storage simulator tests (#247) (#278)

* iOS secure storage simulator tests (#247)

* Remove line that skips test on virtual devices

* Adding keychain-access-groups in Entitlements.plist

* Setting CodeSign entitlements for Debug configuration

* Making same entitlement.plist changes for iOS sample

* Removing specific code sign key

* Removing physical device trait for iOS SecureStorageTests

* Update DeviceTests.iOS.csproj

* Update Samples.iOS.csproj

* Add configs for codesign on release

* Fixes #181 Allowing setting of calibration for heading. (#282)

* GH-254 Update Support Packages, Forms, and Reference Vectors (#279)

* Update Support Packages, Forms, and Reference Vectors

* Bump targetsdk

* Fix android build :)

* Fix build
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.2
Development

Successfully merging this pull request may close these issues.
5 participants
@Costo @dnfclas @rmarinho @jassmith @samhouts